search

r-hub / rhub

R-hub API client
https://r-hub.github.io/rhub/
Other
353 stars 51 forks source link

validate_email() documentation mis-specifies config location #528

Closed ms609 closed 2 years ago

ms609 commented 2 years ago

The documentation of validate_email() in R/email.R@9,10 contains the text

#' On your current platform the file is at
#' \Sexpr{rhub:::email_file()}`

The Sexpr is executed when the package is compiled – so when downloading the binary package from CRAN, it reads

On your current platform the file is at C:\Users\CRAN\AppData\Local/rhub/rhub/validated_emails.csv.

I'm not sure what the most appropriate fix is: perhaps we need a wrapper for email_file() that detects that the package is being built on CRAN, and perhaps replaces the string C:\Users\CRAN\AppData\Local with %APPDATA%?

gaborcsardi commented 2 years ago

I think this was fixed by #434.