1) setLabels → labels_set() (I think, that labels_set() and labels_get() should live in the main hyperSpec package as they give core functionality to work with labels).
2) setLabels_transmute → labels_transmute() (Why is this function needed at all?)
3) setLabels_select → labels_select
4) setLabels_rename → labels_rename
Yet, it is still a bit vague for me, what these functions do and why are they needed. The file with these functions lacks:
description/better explanation, why they are needed;
The family of
setLabels
functions should be renamed as it doesn't follow Tidyverse conventions, e.g., use only lower-case letters.https://github.com/r-hyperspec/hySpc.dplyr/blob/ffbb179f30e3a3c47073f40847577f0dd77a27f0/R/setLabels.R#L19
I suggest renaming:
1)
setLabels
→labels_set()
(I think, thatlabels_set()
andlabels_get()
should live in the main hyperSpec package as they give core functionality to work with labels). 2)setLabels_transmute
→labels_transmute()
(Why is this function needed at all?) 3)setLabels_select
→labels_select
4)setLabels_rename
→labels_rename
Yet, it is still a bit vague for me, what these functions do and why are they needed. The file with these functions lacks: