Is it reasonable to rename `xaxis` to `wl_units` or similar?

r-hyperspec / hySpc.read.spe

Import spe formatted files to hyperSpec

https://r-hyperspec.github.io/hySpc.read.spe/

Other

0 stars 0 forks source link

Closed GegznaV closed 3 years ago

GegznaV commented 3 years ago

Is it reasonable to rename argument xaxis to xaxis_units, wl_units or similar?

@cbeleites, what do you think?

UPDATE

Tasks:

bryanhanson commented 3 years ago

I think renaming would be good -- a lot clearer. wl_units seems pretty consistent with other names we have in various places.