r-hyperspec / hyperSpec

hyperSpec: Tools for Spectroscopy (R package)
https://r-hyperspec.github.io/hyperSpec/
GNU General Public License v3.0
12 stars 3 forks source link

Fix R CMD check issues related to R 4.3.0 #109

Closed GegznaV closed 1 year ago

GegznaV commented 1 year ago

Due to changes in R 4.3.0 (or packages), R CMD check and some unit tests fail. E.g., tests show that some plots changed.

GegznaV commented 1 year ago

For plots, it seams, that the default lattice color schemes have changed:

image

If anyone has more time to investigate the changes and provide a reference/link, your efforts are welcome.

GegznaV commented 1 year ago

wc related tests (randomly) fail on Windows. E.g.: image

Can we defunct wc() function as it was deprecated for quite a long time? What do you think @cbeleites?

GegznaV commented 1 year ago

For now, I'll skip unit tests on wc on Windows too (already skipped on Mac).

GegznaV commented 1 year ago

Closed via #112 and #111