Update introductory vignette

r-lib / R6

Encapsulated object-oriented programming for R

https://R6.r-lib.org

Other

403 stars 56 forks source link

Update introductory vignette #250

Closed IndrajeetPatil closed 2 years ago

IndrajeetPatil commented 2 years ago

adds clarifications about inheritance and cloning
remove hard-coded chunk outputs using error=TRUE option in knitr
consistently uses $foo() convention to refer to class methods
grammatical changes

wch commented 2 years ago

Thanks - I think most of the changes are improvements, but there are some places where the change in wording seems more a matter of taste -- they're changes from my writing style to your writing style. I'm not sure what to do about those instances. In most cases I don't feel strongly about it, but there are some cases where I prefer the original wording.

IndrajeetPatil commented 2 years ago

Ha, I wish I had a style! 😅

A number of these changes are inspired by grammatical and punctuation suggestions from professional version of Grammarly software.

If you feel strongly about certain changes, I am happy to revert them.

IndrajeetPatil commented 2 years ago

bump

IndrajeetPatil commented 2 years ago

This should be ready for a merge. I think I've addressed all of your comments.