Fix libarchive352 compatibility - Githubissues

r-lib / archive

R bindings to libarchive, supporting a large variety of archive formats

https://archive.r-lib.org/

Other

145 stars 17 forks source link

Fix libarchive352 compatibility #72

Closed cielavenir closed 2 years ago

cielavenir commented 2 years ago

this is related to https://github.com/cielavenir/miniarc/commit/80d1406a7c41c2b626fa48137cb19cd31084ccda

cielavenir commented 2 years ago

/cc @RichardBean @jeroen

gaborcsardi commented 2 years ago

Thanks, this is great, we are not stuck at an old version now. Can I ask how you came upon this? Are you using the rwinlib static libraries for your project?

cielavenir commented 2 years ago

there was a short discussion in https://twitter.com/elahieh/status/1496282396840587266 , (when released) libarchive 3.6.1 will fix 7z PPMD decompression (fixed by me), so I'd like r-lib updated as well
for archive_entry_copy_stat thing, I found it independently while investigating system32\archiveint.dll (as a part of miniarc, mentioned above)

gaborcsardi commented 2 years ago

@jeroen Maybe we could try to update to 3.6.1 when it comes out? If that works then I can tell CRAN to also update to that.

jeroen commented 2 years ago

This this also solve the problem described here? https://github.com/r-devel/r-dev-web/blob/master/WindowsBuilds/winutf8/ucrt3/toolchain_libs/mxe/src/libarchive.mk#L8-L14

gaborcsardi commented 2 years ago

Yeah, that's the same thing.

jeroen commented 2 years ago

OK. Can you send a PR to https://github.com/r-windows/rtools-packages when 3.6.1 is released?

gaborcsardi commented 2 years ago

Sure, np, I set up a watch for their releases.

gaborcsardi commented 2 years ago

For the record, PR is here: https://github.com/r-windows/rtools-packages/pull/253