Remove duplicated object file in Makevars

r-lib / commonmark

High Performance CommonMark and Github Markdown Rendering in R

https://docs.ropensci.org/commonmark/

Other

88 stars 11 forks source link

Remove duplicated object file in Makevars #21

Closed georgestagg closed 1 year ago

georgestagg commented 1 year ago

The object file cmark/html.o appears twice in the LIBCMARK list in src/Makevars. This causes some linkers (wasm-ld in my case) to fail with a duplicated symbol error.

jeroen commented 1 year ago

Thanks, good catch. Is it important to get this on CRAN soon?

georgestagg commented 1 year ago

No, I don't think so. I doubt there'll be many people affected at all. It only causes an issue for me because I'm using a strange compiler toolchain.

I'm building my own binaries in any case so I'm happy to just point to the source on GitHub for now.