r-lib / commonmark

High Performance CommonMark and Github Markdown Rendering in R
https://docs.ropensci.org/commonmark/
Other
88 stars 11 forks source link

prevent single tildes from becoming strikethrough #31

Closed zkamvar closed 3 months ago

zkamvar commented 4 months ago

This will fix #25.

jeroen commented 3 months ago

This is does much more than fix the roundtrip? It disables parsing of single-tilde strikethroughs which I think many people actually use?

zkamvar commented 3 months ago

This is does much more than fix the roundtrip? It disables parsing of single-tilde strikethroughs which I think many people actually use?

Yeah, that's a good point, which was brought up in https://github.com/github/cmark-gfm/issues/71#issuecomment-355855609. This change also means that the tildes are now escaped, so I'm going to close this.