Force -coverage -O0 to be after the default -O2

r-lib / commonmark

High Performance CommonMark and Github Markdown Rendering in R

https://docs.ropensci.org/commonmark/

Other

88 stars 11 forks source link

Force -coverage -O0 to be after the default -O2 #5

Closed jimhester closed 8 years ago

jimhester commented 8 years ago

The previous behavior was resulting in a compiler crash which was causing travis to hang.

This fixes the issue on my local vagrant VM, hopefully will also fix it when run on travis.

https://github.com/jimhester/covr/issues/165 is opened to track this issue, I will have a fix in covr devel soon.

jeroen commented 8 years ago

Thanks! Is there something I can suggest to upstream cmark to fix this or is this mostly a bug in covr?

jimhester commented 8 years ago

I think it is just a bug in covr (the intent was to override -02 which wasn't happening) plus a possible bug in commonmark or gcc. It is possible this is due to a bug in commonmark but I am not sure it is worth tracking down.

jeroen commented 8 years ago

OK well thanks for fixing. Is there a small reproducible example with cmark that we can give the cmark author, or does the problem seem to be related to R?