r-lib / coro

Coroutines for R
https://coro.r-lib.org/
Other
160 stars 8 forks source link

CRAN package check results errors #54

Closed alexzwanenburg closed 2 weeks ago

alexzwanenburg commented 1 month ago

In the packages I maintain, I use coro for to generate different combinations of parameters for testing. My continuous integration tests produced an error because coro was not installed, which led me to check CRAN (NOTE: the actual issue with my CI tests may be unrelated).

On CRAN, I noticed that for the latest and dev builds of R, tests within the coro package produces several errors.

Version: 1.0.4
Check: tests
Result: ERROR 
    Running ‘testthat.R’ [18s/22s]
  Running the tests in ‘tests/testthat.R’ failed.
  Complete output:
    > library(testthat)
    > library(coro)
    > 
    > test_check("coro")
    [ FAIL 3 | WARN 0 | SKIP 5 | PASS 202 ]

    ══ Skipped tests (5) ═══════════════════════════════════════════════════════════
    • On CRAN (5): 'test-async.R:25:1', 'test-generator.R:27:3',
      'test-generator.R:34:3', 'test-iterator.R:3:3', 'test-iterator.R:31:3'

    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Error ('test-parser-block.R:63:3'): `{` blocks - nested ─────────────────────
    Error in `node_poke_cdr(prev_refs, nested_refs)`: bad value
    Backtrace:
        ▆
     1. └─coro:::expect_snapshot0(...) at test-parser-block.R:63:3
     2.   ├─rlang::inject(expect_snapshot(!!enquo0(expr), cran = cran)) at tests/testthat/helper-flowery.R:5:5
     3.   └─testthat::expect_snapshot(...)
     4.     └─rlang::cnd_signal(state$error)
    ── Error ('test-parser-block.R:100:3'): `{` blocks - complex nesting ───────────
    Error in `node_poke_cdr(prev_refs, nested_refs)`: bad value
    Backtrace:
        ▆
     1. └─coro:::expect_snapshot0(...) at test-parser-block.R:100:3
     2.   ├─rlang::inject(expect_snapshot(!!enquo0(expr), cran = cran)) at tests/testthat/helper-flowery.R:5:5
     3.   └─testthat::expect_snapshot(...)
     4.     └─rlang::cnd_signal(state$error)
    ── Error ('test-parser-if.R:30:3'): `if` blocks - inner block ──────────────────
    Error in `node_poke_cdr(prev_refs, nested_refs)`: bad value
    Backtrace:
        ▆
     1. └─coro:::expect_snapshot0(...) at test-parser-if.R:30:3
     2.   ├─rlang::inject(expect_snapshot(!!enquo0(expr), cran = cran)) at tests/testthat/helper-flowery.R:5:5
     3.   └─testthat::expect_snapshot(...)
     4.     └─rlang::cnd_signal(state$error)

    [ FAIL 3 | WARN 0 | SKIP 5 | PASS 202 ]
    Error: Test failures
    Execution halted
lionel- commented 1 month ago

yep nothing to worry about, these are test-only failures