search

r-lib / cpp11

cpp11 helps you to interact with R objects using C++ code.
https://cpp11.r-lib.org/
Other
193 stars 46 forks source link

Ext ptr tag #286

Closed thk686 closed 1 year ago

thk686 commented 1 year ago

Adding the ability to get/set tag on external pointer class.

romainfrancois commented 1 year ago

I've messed with the history in this PR. I'll extract the relevant changes in external-pojnter.hpp and test-external-pointer.cpp and do it again. Sorry about the inconvenience.

thk686 commented 1 year ago

No worries. Actually, I ended up not using tags in my experiment. But it would be helpful to wrap setting the protect object as I use that a lot.

On Tue, Oct 11, 2022 at 11:55 AM Romain François @.***> wrote:

I've messed with the history in this PR. I'll extract the relevant changes in external-pojnter.hpp and test-external-pointer.cpp and do it again. Sorry about the inconvenience.

— Reply to this email directly, view it on GitHub https://github.com/r-lib/cpp11/pull/286#issuecomment-1274997449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEQXSNZUYCKZIDTKVCEFBLWCWLXDANCNFSM6AAAAAAQPZAV7E . You are receiving this because you authored the thread.Message ID: @.***>

romainfrancois commented 1 year ago

Ok, let me close this then, and I'll pick up #287 in a new PR.