search

r-lib / cpp11

cpp11 helps you to interact with R objects using C++ code.
https://cpp11.r-lib.org/
Other
193 stars 46 forks source link

Vendoring path #340

Closed pachadotdev closed 8 months ago

pachadotdev commented 8 months ago

As @krlmlr suggested, it might be better to vendor to src/vendor instead of inst

This PR implements that and also a better handling and messages about Makevars

The only error I can't see why it happens is

══ Results ══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 6.8 s

── Failed tests ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error (test-vendor.R:13:5): cpp_vendor: errors if cpp11 is already vendored
Error: cpp11 is not installed
Backtrace:
    ▆
 1. └─cpp11::cpp_vendor(pkg_path(pkg)) at test-vendor.R:13:5

Error (test-vendor.R:25:5): cpp_vendor: vendors cpp11
Error: cpp11 is not installed
Backtrace:
    ▆
 1. └─cpp11::cpp_vendor(pkg_path(pkg)) at test-vendor.R:25:5

[ FAIL 2 | WARN 0 | SKIP 0 | PASS 107 ]
krlmlr commented 8 months ago

FWIW, you can update a PR by pushing or force-pushing to the same branch.

pachadotdev commented 8 months ago

Thx! I realized that the other branch introduced to many changes. I tested this one by re-installing roxygen after installing this cpp11 modification, and I also tested creating a dummy package.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Kirill Müller @.> Sent: Thursday, November 9, 2023 12:14:31 AM To: r-lib/cpp11 @.> Cc: Mauricio Andres Vargas Sepulveda @.>; State change @.> Subject: Re: [r-lib/cpp11] Vendoring path (PR #340)

FWIW, you can update a PR by pushing or force-pushing to the same branch.

— Reply to this email directly, view it on GitHubhttps://github.com/r-lib/cpp11/pull/340#issuecomment-1803175093, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACM7UOJWVJ4KNE6WXREVC23YDRRDPAVCNFSM6AAAAAA7DWCJDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBTGE3TKMBZGM. You are receiving this because you modified the open/close state.Message ID: @.***>