r-lib / cpp11

cpp11 helps you to interact with R objects using C++ code.

https://cpp11.r-lib.org/

Other

193 stars 46 forks source link

Vendoring #341

Closed pachadotdev closed 4 months ago

pachadotdev commented 8 months ago

340 but without the breaking changes

pachadotdev commented 5 months ago

@krlmlr hi, this allows u to vendor to src/vendor! @hadley i keep the unlink() function in vendor.R examples to pass the local check(), but that then creates problems with pkgdown

krlmlr commented 5 months ago

Thanks. I'd wait for a comment on if we want to vendor into src/vendor at all. Perhaps there's a reason for vendoring into inst/include ?

pachadotdev commented 5 months ago

Thanks. I'd wait for a comment on if we want to vendor into src/vendor at all. Perhaps there's a reason for vendoring into inst/include ?

what i saw with check(), is that it doesn't like to put files in src, but if i vendor in src/vendor in a pkg project, it passes all checks for that another pkg

krlmlr commented 5 months ago

The checks in this PR are failing
This PR seems to have a bit of noise
We don't know the maintainers' perspective on if this PR is a good, so I'm not sure if it's worth addressing the first two issues at all

Let's not spend too much time here for now?

pachadotdev commented 5 months ago

The checks in this PR are failing

This PR seems to have a bit of noise

We don't know the maintainers' perspective on if this PR is a good, so I'm not sure if it's worth addressing the first two issues at all

Let's not spend too much time here for now?

sure, i was following from the vendoring in https://github.com/r-dbi/RPostgres/tree/main/src/vendor/boost