search

r-lib / cpp11

cpp11 helps you to interact with R objects using C++ code.
https://cpp11.r-lib.org/
Other
193 stars 46 forks source link

Ensure format strings pass check in R-devel/Windows #345

Closed paleolimbot closed 7 months ago

paleolimbot commented 7 months ago

Not sure exactly why this issue popped up on CI ( https://github.com/apache/arrow/pull/38894#issuecomment-1828488227 ), but it seems that at least one format string has %x (which expects an int) where I think the intention was to print memory addresses (i.e., %p). Our CI issue is probably because we're being a tad to aggressive about converting errors to warnings, but it seemed like an easy fix while I was taking a look!

paleolimbot commented 7 months ago

(CI failure seems to be related to differences in snapshot output that doesn't seem to be related to printing the protected list)

DavisVaughan commented 7 months ago

Thanks!