search

r-lib / crancache

Transparent caching of CRAN package files - WORK IN PROGRESS!
Other
28 stars 2 forks source link

Rename warnings #17

Closed hadley closed 7 years ago

hadley commented 7 years ago

During a long revdep run, I see quite a few:

In file.rename(file.path(dir, pkgs_new), file.path(dir, pkgs)) :
  cannot rename file '/Users/hadley/Library/Caches/R-crancache/other/bin/macosx/el-capitan/contrib/3.4/PACKAGES.rds.new' to '/Users/hadley/Library/Caches/R-crancache/other/bin/macosx/el-capitan/contrib/3.4/PACKAGES.rds', reason 'No such file or directory'

I'm re-running now with options(warn = 2) to at least get a traceback.

gaborcsardi commented 7 years ago

That would be good, because I can't find a single file.rename call:

~/works
❯ grep file.rename revdepcheck/R/*

~/works
❯ grep file.rename r-hub/crancache/R/*
hadley commented 7 years ago 
14: file.rename(file.path(dir, pkgs_new), file.path(dir, pkgs))
13: write_packages_files(dir, db_file)
12: create_empty_PACKAGES(dir) at repos.R#22
11: create_cache_if_needed() at repos.R#13
10: get_cached_repos() at is_active.R#20
9: get_crancache_repos() at available-packages.R#26
8: available_packages() at deps.R#26
7: cran_deps(pkgname) at deps-install.R#35
6: deps_install_opts(pkgdir, pkgname, quiet = state$options$quiet) at deps-install.R#78
5: deps_install_task(state, task) at event-loop.R#261
4: do_task(state, task) at event-loop.R#64
3: run_event_loop(state) at revdepcheck.R#158
2: revdep_run_check(pkg, quiet = quiet, timeout = timeout, num_workers = num_workers) at revdepcheck.R#46
1: revdepcheck::revdep_check(num_workers = 10, bioc = F)
gaborcsardi commented 7 years ago

I have seen these, too. They are coming from cranlike, the locking in cranlike is not proper I think.

gaborcsardi commented 7 years ago

They should be harmless btw. except that they might cause the visible downloads, in revdepcheck, potentially: #37.

gaborcsardi commented 7 years ago

Moved over to cranlike