`debugme()` gains `level` argument

[krlmlr]

This allows evaluating the message lazily, and also fixes issues with detecting the appropriate log level.

The msg argument no longer contains the "!DEBUG" header, technically it's a breaking change but maybe irrelevant?

[codecov-io]

Codecov Report

Merging #48 (8b26d4e) into master (136c159) will decrease coverage by 1.03%. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   97.87%   96.84%   -1.04%     
==========================================
  Files           6        6              
  Lines         188      190       +2     
==========================================
  Hits          184      184              
- Misses          4        6       +2     

Impacted Files	Coverage Δ
R/instrument.R	97.50% <83.33%> (-2.50%)	:arrow_down:
R/debug.R	95.58% <100.00%> (-1.52%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 136c159...8b26d4e. Read the comment docs.

[gaborcsardi]

Thanks! We could still keep the header in the message, though, and then there is no breaking change, no?

[krlmlr]

If backward-compatibility is important, I'm sure there's a way. Is it?

We could:

• use a non-exported function as an entry point, i.e., use quote(debugme:::debug_private) (or an equivalent) instead of quote(debugme::debug)
• set level = NULL as default and strip the "!+DEBUG" only if a level is given
• set level = NULL as default, use it if given, and always strip "!+DEBUG" (in the understanding that no sensible logging message starts with this string)

Do you have a preference?

[gaborcsardi]

It is not actually very important, I think. Let's just merge this, and we'll see in the revdep checks...