search

r-lib / devtools

Tools to make an R developer's life easier
https://devtools.r-lib.org
Other
2.39k stars 760 forks source link

Add linting action #2431

Closed hadley closed 2 years ago

hadley commented 2 years ago

Fixes #2430

hadley commented 2 years ago

@jennybc I think it's slightly better to put the lint config in .lintr because then it's also used when you call lintr::lint_package() locally.

jennybc commented 2 years ago

@jennybc I think it's slightly better to put the lint config in .lintr because then it's also used when you call lintr::lint_package() locally.

Oh I agree. I think usethis ended up the way it did because I couldn't find a working example of doing such a thing and I got frustrated and inlined the whole thing.

Also based on the usethis experience, I would push a commit introducing an undesirable function, just to make sure it gets caught and reported the way you expect.