r-lib / devtools

Tools to make an R developer's life easier
https://devtools.r-lib.org
Other
2.37k stars 755 forks source link

Revisiting typo in `release()` #2518

Closed Ilia-Kosenkov closed 1 year ago

Ilia-Kosenkov commented 1 year ago

While preparing for a package release, I ran devtools::check_win_devel(), which prompted me with something like this:

> devtools::check_win_devel()
Building windows version of package (version)
ℹ Using R-devel with win-builder.r-project.org.
Email results to e@ma.il?

1: Yup
2: I forget
3: Uhhhh... Maybe?

What caught my eye was option two, 'I forget'. To me, a non-native English speaker, this sounds grammatically incorrect. The present tense is usually used to describe a recurring event, which is not really suitable for a situation when someone forgot their email.

This option distinctly stands out among all other no options found here: https://github.com/r-lib/devtools/blob/69d610414c69748d7b5bbe7d890e228bdb5b18ff/R/release.R#L151

Reasonable alternatives would be:

I also found an issue from 2020 #2231 which discusses the same topic, but the author seemed to have closed it too fast so it got no real attention from the maintainers.

hadley commented 1 year ago

This is a generic prompt for yes/no questions, and while casual, I think "I forget" is fine in this context.