r-lib / devtools

Tools to make an R developer's life easier
https://devtools.r-lib.org
Other
2.37k stars 755 forks source link

Loading devtools should not cause shiny to be loaded #2523

Closed wch closed 12 months ago

wch commented 12 months ago

Currently, loading devtools causes shiny to be loaded, but it shouldn't. This is because devtools imports miniUI, which imports shiny.

Searching the code for miniUI, I see only this (and the corresponding entry in NAMESPACE):

#' @importFrom miniUI miniPage

Searching for miniPage, I see no other uses of it. So I think miniUI can be removed as a dependency, and I think this will make it so shiny will no longer be needed at all by devtools.

jennybc commented 12 months ago

Closing in favor of #2524