r-lib / devtools

Tools to make an R developer's life easier
https://devtools.r-lib.org
Other
2.37k stars 755 forks source link

These tests do more harm than good #2542

Closed jennybc closed 8 months ago

jennybc commented 8 months ago

Closes #2477

As written, these tests (indirectly) call remotes::update_packages("roxygen2") which can cause package installation on any machine that runs the tests. And this installation is NOT scoped correctly, i.e. to a temporary library.

I got fairly far into refactoring the tests, when I realized that fixing them introduced more complexity than was worth it. Passing arguments along isn't a tricky operation. devtools is better off without these tests.