search

r-lib / diffviewer

HTML widget to visually compare files
http://diffviewer.r-lib.org
Other
58 stars 7 forks source link

Remove unused files #12

Closed wch closed 2 years ago

wch commented 3 years ago

Closes #10. This PR removes inst/htmlwidgets/diffviewer.js and inst/htmlwidgets/diffviewer.yaml. I believe those files are unused (I tested with visual_diff() and visual_diff_render() in a Shiny application.

hadley commented 3 years ago

@jbkunst do you happen to remember why we have these two versions?

wch commented 3 years ago

In shinytest, there is an inst/htmlwidgets/diffviewer.js and inst/htmlwidgets/diffviewer.yaml. It's there because there is a call to htmlwidgets::createWidget(name = "diffviewer"), and that expects the .js and .yaml file to be there.

In the diffviewer package, there is a call to createWidget(name = "visual_diff"), and there are the corresponding files inst/htmlwidgets/visual_diff.js and inst/htmlwidgets/visual_diff.yaml. There is not a call to createWidget(name = "diffviewer") in this package.

I think the inst/htmlwidgets/diffviewer.js and yaml files in this package are probably left over from the migration, but I don't know for sure.