Find alternative to CSV to array

r-lib / diffviewer

HTML widget to visually compare files

http://diffviewer.r-lib.org

Other

58 stars 7 forks source link

Find alternative to CSV to array #7

Closed hadley closed 4 years ago

hadley commented 4 years ago

http://www.speqmath.com/tutorials/csv2array/ doesn't have any licensing information so we can't use it.

@jbkunst can you please find an alternative?

jbkunst commented 4 years ago

@hadley

I made a quick research. I found and implemented PapaParse (https://github.com/mholt/PapaParse), looks a good alternative:

MIT License
Active development (last commit 9 days ago)
Robust in terms of options and error handling
9k starts on gh

hadley commented 4 years ago

Looks good, thanks!

In the future, when including JS code in a package, I'd recommending also always copying the license into the lib folder. And for CRAN submission you also need to make sure the author is mentioned in the DESCRIPTION and the included code is noted in LICENSE.note.

jbkunst commented 4 years ago

Thank you. I will take the considerations from here forward. I will make the changes via PR.