search

r-lib / gargle

Infrastructure for calling Google APIs from R, including auth
https://gargle.r-lib.org/
Other
113 stars 33 forks source link

Refactor GCE flow #247

Closed jennybc closed 1 year ago

jennybc commented 1 year ago

I'm refactoring the GCE flow. credentials_gce() is sort of the last semi-untouched frontier for me, within gargle. I have made some changes here before, but with a very light hand.

My cumulative experience with gargle and even with the GCE flow has now reached a point where it feels right to refactor this to be more like the other flows and to be more natural to me.

Issue-wise, #216 is the most relevant. Closes #216.

jennybc commented 1 year ago

@atheriel I can't tag you as a reviewer, but I would welcome your 👀 on this.

atheriel commented 1 year ago

My understanding of the service account story on GCE is not strong enough to spot actual issues with the implementation, but overall the changes make sense to me and seem consistent with what I've seen in the external account flow.