r-lib / gargle

Infrastructure for calling Google APIs from R, including auth
https://gargle.r-lib.org/
Other
113 stars 33 forks source link

Release gargle 1.5.0 #262

Closed jennybc closed 1 year ago

jennybc commented 1 year ago

Prepare for release:

Submit to CRAN:

Wait for CRAN...

jennybc commented 1 year ago

urlchecker gives 2 false positives:

> urlchecker::url_check()
✖ Error: vignettes/gargle-auth-in-client-package.Rmd:125:19 Error: Failed to connect to localhost port 80 after 11 ms: Connection refused
#> redirect_uris: http://localhost
                  ^~~~~~~~~~~~~~~~
✖ Error: vignettes/troubleshooting.Rmd:234:15 404: Not Found
  base_url = "https://www.googleapis.com"
              ^~~~~~~~~~~~~~~~~~~~~~~~~~

The first (http://localhost) is in a code comment (commented output). The second https://www.googleapis.com is in actual code.

Will be interesting to see if they show up in check_win_devel().

Update: no, these were not reported by check_win_devel(), suggesting there's some difference between CRAN's actual checks and what urlchecker is doing right now.