r-lib / generics

Common generic methods
https://generics.r-lib.org/
Other
61 stars 13 forks source link

Include re-exporting advice in README #6

Closed hadley closed 6 years ago

hadley commented 6 years ago

i.e. do you expect users of this package to re-export it or depend on it?

topepo commented 6 years ago

Depend. For example, recipes can just import modelgenerics instead of broom and I get the same functionality with a smaller footprint.

hadley commented 6 years ago

Will recipes "depend" on modelgenerics, or "import" it?

topepo commented 6 years ago

Right now it depends on broom but I've never liked that. I could import modelgenerics and reexport tidy.

hadley commented 6 years ago

I think we are talking at cross-purposes here. There are two ways that a package that uses modelgenerics could make the generics available to users:

I think you should document which is preferred.

alexpghayes commented 6 years ago

I've been re-exporting. There's a broom vignette on how to do this in progress here. Also a minimal demonstration package.