r-lib / gert

Simple git client for R
https://docs.ropensci.org/gert/
Other
148 stars 32 forks source link

http://r-lib.github.io/gert/get-libgit2-linux.sh uses --no-echo from R (>= 4.0.0) #119

Closed HenrikBengtsson closed 3 years ago

HenrikBengtsson commented 3 years ago

Just an FYI. I noticed that http://r-lib.github.io/gert/get-libgit2-linux.sh uses --no-echo in:

${R_HOME}/bin/R --no-echo -q -e "curl::curl_download('$URL','bundle.tar.gz')"

That CLI option was introduced in R 4.0.0. In R (< 4.0.0) it'll produce a warning, which might be harmless but add clutter.


BTW, to be conservative, ${R_HOME} should be quoted to handle spaces, e.g.

"${R_HOME}"/bin/R ...

or

"${R_HOME}/bin/R" ...

depending on personal preferences. The same applies to ${PWD}.