search

r-lib / gert

Simple git client for R
https://docs.ropensci.org/gert/
Other
146 stars 31 forks source link

Commits made with gert are not gpg signed #186

Open czeildi opened 1 year ago

czeildi commented 1 year ago

I have gpg signing set up for every commit, i.e. commit.gpgsign is true and if I commit from the command line, all my commits are indeed gpg signed.

If I commit with gert::git_commit, my commits are not signed.

I would expect them to be signed, or show a warning that the commits are not signed.

Or if this is out of scope, maybe a note could be added to the documentation.

I am not sure how to set up a proper reprex, but here is a sandbox repository where I experimented: https://github.com/czeildi/gert-sandbox/commits/main

czeildi commented 1 year ago

for context: originally I burned myself using usethis::pr_merge_main on a repository that requires all commits to be signed for merging a PR and tracked that gert is used under the hood.