Fix incorrect pointer argument to git_commit_create

r-lib / gert

Simple git client for R

https://docs.ropensci.org/gert/

Other

146 stars 31 forks source link

Fix incorrect pointer argument to git_commit_create #214

Closed jsks closed 3 months ago

jsks commented 4 months ago

This should fix #213 where the latest version of gcc fails because libgit2 expects a pointer of type git_commit * const [] to git_commit_create.

jeroen commented 3 months ago

As you can see in the CI, this breaks the check for older libgit2 versions...

Perhaps the only solution is to condition code on the libgit2 version as we do elsewhere using the AT_LEAST_LIBGIT2() macro. However this will get even more messy if libgit2 reverts this accidental API change for future versions...

jeroen commented 3 months ago

Closed via https://github.com/r-lib/gert/commit/fb07cf76eb50efe6490d98fbac613cfe0cff0115