r-lib / gh

Minimalistic GitHub API client in R
https://gh.r-lib.org
Other
223 stars 52 forks source link

Switch from httr to httr2 #174

Closed hadley closed 1 year ago

hadley commented 1 year ago

And add rate limiting. Fixes #67.

hadley commented 1 year ago

@gaborcsardi if we decided to go down this path, I'll consider testing more broadly, doing some more refactoring and adding tests to get better coverage. But I have invested relatively little time at this point, so it would be easier enough to give it up.

A few reasons why it'd be worthwhile to switch to httr2:

hadley commented 1 year ago

Hmmm, those tests assume that you have a PAT created with our default scopes. I can skip if the scopes aren't as expected, if you want.

gaborcsardi commented 1 year ago

Yeah, I think we need to skip, or add back the GH_TESTING token on the CI and skip if it is not set, because GITHUB_TOKEN might not have the same scopes for all the developers and also for the CI jobs.