r-lib / gh

Minimalistic GitHub API client in R
https://gh.r-lib.org
Other
223 stars 52 forks source link

Add support for a dynamic dots #187

Closed pawelru closed 11 months ago

pawelru commented 11 months ago

I would like to do the following:

x <- list(owner = "r-lib", repo = "gh")
gh("/repos/{owner}/{repo}/issues", !!!x)
gaborcsardi commented 11 months ago

It is unlikely that we are going to do this, because it considerable amount of work, and you can already do:

x <- list(owner = "r-lib", repo = "gh")
gh("/repos/{owner}/{repo}/issues", .params = x)
pawelru commented 11 months ago

Thanks. I somehow missed .params argument. Stupid me 🤦 . Then I guess it make little sense to unpack the list of params as the list class is natively supported. I am happy to close that issue but leaving this for your assessment.

gaborcsardi commented 11 months ago

No worries at all.