search

r-lib / gh

Minimalistic GitHub API client in R
https://gh.r-lib.org
Other
223 stars 52 forks source link

Recommend gitcreds more? #194

Closed maelle closed 6 months ago

maelle commented 6 months ago

I was reading the docs/code to find where the fallback on the GITHUB_TOKEN environment variable happens (in gitcreds :sweat_smile:) and noticed that while gitcreds docs state

#' However, we still suggest that you add your token to the git credential
#' store with `gitcreds_set()` and remove `GITHUB_PAT` from your
#' `.Renviron` file. The credential store is more secure than storing
#' tokens in files, and command line git also uses the credential store
#' for password-less authentication.

here in gh,

https://github.com/r-lib/gh/blob/1ac24e436647c608b145e848ea994fe99c8ffe8f/R/gh.R#L43-L46

gaborcsardi commented 6 months ago

Well, a PR is welcome. 😉

maelle commented 6 months ago

Done!