Original issue suggested replacing mockery with testthat::with_mock, however the usage of mockery was to test parameter handling (accepting via both ... and a .params arg) so naive replacement caused an infinitely recursive call to gh_build_request.
Resolved by refactoring parameter handling into its own function, .parse_params(), which is easier to test conventionally
Closes #197 as part of tidy dev day
Original issue suggested replacing mockery with
testthat::with_mock, however the usage of mockery was to test parameter handling (accepting via both ... and a .params arg) so naive replacement caused an infinitely recursive call to gh_build_request.Resolved by refactoring parameter handling into its own function,
.parse_params(), which is easier to test conventionally