search

r-lib / gitcreds

Query git credentials from R
https://gitcreds.r-lib.org/
Other
27 stars 10 forks source link

Fix older git versions on Windows #22

Closed gaborcsardi closed 3 years ago

gaborcsardi commented 3 years ago

The issue is that system2() uses writeLines() to write out the standard input to a file, and this uses \r\n EOLs on Windows. Older git versions or git for Windows installers (before 2.25.1) do not handle \r\n as EOL when dealing with credentials.

codecov-io commented 3 years ago

Codecov Report

Merging #22 (044f98f) into master (50a1608) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files           3        3           
  Lines         172      172           
=======================================
  Hits          167      167           
  Misses          5        5
Impacted Files Coverage Δ
R/git-auth.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50a1608...044f98f. Read the comment docs.