search

r-lib / httr2

Make HTTP requests and process their responses. A modern reimagining of httr.
https://httr2.r-lib.org
Other
235 stars 56 forks source link

Check password more lazily #499

Closed hadley closed 2 months ago

hadley commented 2 months ago

Maybe fixes #498

@exetico I don't have any way to debug this because I don't have access to an API that uses this style of auth, but I changed two lines that looked suspicious when I took a second look.

exetico commented 2 months ago

I've executed install_github('https://github.com/r-lib/httr2/tree/password-prompts'), replaced all instances of the package and restarted my R session.

Now I'm not getting the 2nd. popup. That was a easy fix 😄.

To show my gratitude, I've also spinned up my local API instance, and bumped down the expires_in time to 20 sec, and after 20 sec was gone for good, it did reprompt me, as expected.

Thank you!

I've read the policy of "how often to release updates to R-packages", and I noticed that 1.0.1 was released at the 1. of april.

Do you have any idea on when this can be released (and available on CRAN)?

hadley commented 2 months ago

I'm planning on a release next week

hadley commented 2 months ago

Thanks so much for double checking!