search

r-lib / hugodown

Make websites with hugo and RMarkdown
https://hugodown.r-lib.org
Other
166 stars 24 forks source link

Bring back other newline removed in #92 #109

Closed DavisVaughan closed 1 year ago

DavisVaughan commented 1 year ago

92 removed two newlines

After https://github.com/r-lib/hugodown/issues/106 was reported, https://github.com/r-lib/hugodown/pull/108 restored one of the two.

But when I render with main hugodown, I am now seeing that we don't have enough newlines, and it seems like restoring the other one that was removed fixes it. I do not understand why.

I also rendered the usethis 2.0.0 post with this PR installed, and I don't see the double new line that was present in @jennybc's image here after git_protocol(), so idk what changed but it was probably pandoc or knitr? https://github.com/r-lib/hugodown/issues/91#issue-796266452

Screen Shot 2022-11-23 at 12 13 01 PM Screen Shot 2022-11-23 at 12 13 24 PM
hadley commented 1 year ago

This also fixes some problems that I was seeing in the purrr blog post, so I think it's good to merge.

DavisVaughan commented 1 year ago

do you know what was happening in the coverage check?