search

r-lib / isoband

isoband: An R package to generate contour lines and polygons.
https://isoband.r-lib.org
Other
131 stars 14 forks source link

Build fails with newest glibc #25

Closed Enchufa2 closed 3 years ago

Enchufa2 commented 3 years ago

Same issue as https://github.com/r-lib/testthat/issues/1373, because you include the source of testthat in this package: SIGSTKSZ is not a constant anymore. You can check e.g. in Fedora rawhide.

clauswilke commented 3 years ago

@Enchufa2 Thanks for letting us know.

@hadley @jimhester Can somebody from the tidyverse team take this on? As a reminder, we vendored the testthat code here to remove the indirect dependency of ggplot2 on testthat.

clauswilke commented 3 years ago

Looks like it's just a matter of updating the catch code to the latest release.

clauswilke commented 3 years ago

@jimhester I saw your comment in the testthat repo about Catch1 vs Catch2. Would it make sense here to switch to Catch2? isoband already requires C++11.

jimhester commented 3 years ago

No, I think I would probably just use the same fix here as in https://github.com/r-lib/testthat/pull/1403

clauswilke commented 3 years ago

Sounds good to me, thanks!

clauswilke commented 3 years ago

@Enchufa2 Could you try with the latest development version? This should be fixed now. If it looks good on your end I'll release a patch version soon.

Enchufa2 commented 3 years ago

LGTM!