r-lib / keyring

:closed_lock_with_key: Access the system credential store from R
https://keyring.r-lib.org/
Other
196 stars 28 forks source link

vault backend #42

Closed richfitz closed 6 years ago

richfitz commented 7 years ago

I'm working on a package that wraps vault - https://github.com/vimc/vaultr

So two related thoughts:

gaborcsardi commented 7 years ago

@richfitz

It does make sense to have a vault backend. I am not sure which package it would go to. Maybe a third package?

I can put keyring on cran, no changes are needed to it.

Sent from my Samsung SM-G361F using FastHub

richfitz commented 7 years ago

Looking at the structure of the package, I was thinking I could add it directly to vaultr. But a third package might make sense too (less sense if I use keychain to fetch things like github tokens to authenticate with vault)

richfitz commented 7 years ago

(and reading my initial comment please read "add vault as an alternative backend to your package" as add vault as an alternative backend for your package").

Is there documentation for writing backends, especially on testing that they conform to expected behaviour?

gaborcsardi commented 7 years ago

MAkes sense. You can decide if you want it in another package or not.

As for backend docs, probably not (sorry, on my phone now), but it should be pretty straightforward, just look at an existing backend. I can add docs if you are unsure about sg.

richfitz commented 7 years ago

Cool, sounds good. I have no crazy timeline on this but will keep you posted

gaborcsardi commented 6 years ago

I will close this now for lack of activity. Please reopen as needed.