r-lib / keyring

:closed_lock_with_key: Access the system credential store from R
https://keyring.r-lib.org/
Other
196 stars 28 forks source link

Add file-based backend #54

Closed nbenn closed 6 years ago

nbenn commented 6 years ago

Ad #52

codecov-io commented 6 years ago

Codecov Report

Merging #54 into master will increase coverage by 17.53%. The diff coverage is 87.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #54       +/-   ##
===========================================
+ Coverage    36.5%   54.03%   +17.53%     
===========================================
  Files          13       14        +1     
  Lines        1249     1312       +63     
===========================================
+ Hits          456      709      +253     
+ Misses        793      603      -190
Impacted Files Coverage Δ
R/default_backend.R 87.5% <ø> (-2.25%) :arrow_down:
R/assertions.R 100% <100%> (ø) :arrow_up:
R/backend-file.R 87.02% <87.02%> (ø)
R/backend-secret-service.R 0% <0%> (-6.61%) :arrow_down:
R/backend-class.R 5.33% <0%> (-5.06%) :arrow_down:
src/keyring_secret_service.c 0% <0%> (-5.03%) :arrow_down:
R/backend-macos.R 73.94% <0%> (-1.06%) :arrow_down:
R/backend-wincred.R 1.88% <0%> (+0.11%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdaaab7...2819a85. Read the comment docs.

nbenn commented 6 years ago

Sorry for the delay in finishing up the requested changes. I think I now incorporated everything you asked for. Let me know if you have any additional stuff you want me to modify, or also if you want me to explain something in more detail.

gaborcsardi commented 6 years ago

Thanks! I'll look at it ASAP.

gaborcsardi commented 6 years ago

Great stuff, thank you!

gaborcsardi commented 6 years ago

OK, after a better look, I think it is not optimal that unlocking a keyring in one R session makes it impossible to use it in another session. This might have been a misunderstanding between us. I'll fix this.