Closed nbenn closed 6 years ago
Merging #54 into master will increase coverage by
17.53%
. The diff coverage is87.18%
.
@@ Coverage Diff @@
## master #54 +/- ##
===========================================
+ Coverage 36.5% 54.03% +17.53%
===========================================
Files 13 14 +1
Lines 1249 1312 +63
===========================================
+ Hits 456 709 +253
+ Misses 793 603 -190
Impacted Files | Coverage Δ | |
---|---|---|
R/default_backend.R | 87.5% <ø> (-2.25%) |
:arrow_down: |
R/assertions.R | 100% <100%> (ø) |
:arrow_up: |
R/backend-file.R | 87.02% <87.02%> (ø) |
|
R/backend-secret-service.R | 0% <0%> (-6.61%) |
:arrow_down: |
R/backend-class.R | 5.33% <0%> (-5.06%) |
:arrow_down: |
src/keyring_secret_service.c | 0% <0%> (-5.03%) |
:arrow_down: |
R/backend-macos.R | 73.94% <0%> (-1.06%) |
:arrow_down: |
R/backend-wincred.R | 1.88% <0%> (+0.11%) |
:arrow_up: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bdaaab7...2819a85. Read the comment docs.
Sorry for the delay in finishing up the requested changes. I think I now incorporated everything you asked for. Let me know if you have any additional stuff you want me to modify, or also if you want me to explain something in more detail.
Thanks! I'll look at it ASAP.
Great stuff, thank you!
OK, after a better look, I think it is not optimal that unlocking a keyring in one R session makes it impossible to use it in another session. This might have been a misunderstanding between us. I'll fix this.
Ad #52
keyring_version
, a noncenonce
stored as hex string and a random stringintegrity_check
used to make sure that all keys in this keyring are encrypted using the same nonce/keyservice_name
,user_name
andsecret
(stored as hex string)keyrings
env is used, which contains an env per unlocked keyring; this is the best I could come up with that is compatible with how theapi
functions workeach of the keyring envs can store
key
)nonce
)check
)items
)all except the unlock key is not strictly necessary as this information can at any time be read from the keyring file; however as retrieving any piece of info from the file requires reading and parsing of the whole file, the important stuff is cached
get()