r-lib / keyring

:closed_lock_with_key: Access the system credential store from R
https://keyring.r-lib.org/
Other
196 stars 28 forks source link

add a prompt option to change the message of the window asking for password #65

Closed Guillaume-Lombardo closed 3 years ago

Guillaume-Lombardo commented 5 years ago

as spoked in issue #64 : option to change the prompt in keyring_set()

codecov-io commented 5 years ago

Codecov Report

Merging #65 into master will decrease coverage by 11.8%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #65       +/-   ##
===========================================
- Coverage   47.51%   35.71%   -11.81%     
===========================================
  Files          14       14               
  Lines        1591     1078      -513     
===========================================
- Hits          756      385      -371     
+ Misses        835      693      -142
Impacted Files Coverage Δ
R/api.R 0% <0%> (-35.3%) :arrow_down:
R/backend-secret-service.R 0% <0%> (-6.74%) :arrow_down:
R/backend-macos.R 3.36% <0%> (-72.27%) :arrow_down:
R/backend-file.R 88.09% <0%> (-0.6%) :arrow_down:
R/backend-wincred.R 1.83% <0%> (ø) :arrow_up:
src/keyring_macos.c 0% <0%> (-87.37%) :arrow_down:
R/assertions.R 75% <0%> (-25%) :arrow_down:
R/utils.R 20% <0%> (-20%) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6655632...10d8f6d. Read the comment docs.

gaborcsardi commented 3 years ago

@Guillaume-Lombardo I am closing this now, but please let me know if you want to finish this. Thanks!