r-lib / later

Schedule an R function or formula to run after a specified period of time.
https://r-lib.github.io/later
Other
137 stars 27 forks source link

Does the call stack need to be empty for the later code to be run? #159

Open nx10 opened 2 years ago

nx10 commented 2 years ago

I use later in my package to call R from a C++ background thread in a safe way. From looking in the source code I assume later waits for some regular callbacks and, if the call stack is empty the later code is run. (Please correct me if these assumptions are wrong)

Does the call stack need to be completely empty for technical reasons or could later run code while R is in a loop or executing other code? For example: I would like to execute code while R waits for keyboard inputs:

later::later(function() { print("Hello from later") }, 1) 
readline("Waiting for keyboard input") # wait for more than 1 sec. then pressing enter

Expected output:

(Text is printed 1 sec after execution, before enter is pressed)

Waiting for keyboard input
[1] "Hello from later"
[1] ""

Actual output:

(Text is printed after enter is pressed)

Waiting for keyboard input
[1] ""
[1] "Hello from later"

Possibly similar issue: https://github.com/r-lib/later/issues/152

wch commented 2 years ago

Callbacks in the event loop can be run in these two ways:

So you can run the event loop at any time by calling run_now().

nx10 commented 2 years ago

Thank you for the quick response. Could you maybe go into more detail why the call stack needs to be empty? Is this a technical limitation or a design decision by later?

Edit: It seems like Rhttpd.c does not check the call stack. Would it be possible to add a priority flag to later which disables the check?