search

r-lib / lintr

Static Code Analysis for R
https://lintr.r-lib.org
Other
1.16k stars 184 forks source link

Add expect_no_lint #2582

Closed F-Noelle closed 1 month ago

F-Noelle commented 1 month ago

This pull request is meant to address issue #2580.

This is probably the easiest way to add such a function. I assume with time the tests should be updated to use one over the other.

AshesITR commented 1 month ago

Thanks for this. I would suggest adding a NEWS bullet crediting yourself and citing the issue number, as well as updating our test suite to use the new function.

MichaelChirico commented 1 month ago

updating our test suite to use the new function.

I would hold this for follow-up actually, that will be several-hundred-lines change, better to keep this PR focused on the minimal change to get this added.

To that end we probably want a expect_no_lint_linter() 😄

F-Noelle commented 1 month ago

Added NEWS item and yeah the test suit update will be massive.

I actually thought about an expect_no_lint_linter(). It kind of is obvious when you think about it, but it is also super silly.😄

AshesITR commented 1 month ago

Follow up PR for the migration sounds fine.