search

r-lib / lintr

Static Code Analysis for R
https://lintr.r-lib.org
Other
1.19k stars 184 forks source link

Print a message when no lints found #2643

Closed IndrajeetPatil closed 1 month ago

IndrajeetPatil commented 1 month ago

Closes #2640

library(lintr)
lint(text = "x <- 1L", linters = all_linters())
#> ℹ No lints found.

Created on 2024-08-04 with reprex v2.1.1

IndrajeetPatil commented 1 month ago

Windows failures seem spurious:

> checking top-level files ... NOTE
  Non-standard file/directory found at top level:
    'install.ps1'
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.96%. Comparing base (f0d9407) to head (63b0017). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2643 +/- ## ======================================= Coverage 97.96% 97.96% ======================================= Files 126 126 Lines 5760 5761 +1 ======================================= + Hits 5643 5644 +1 Misses 117 117 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

IndrajeetPatil commented 1 month ago

LGTM. The Windows failure looks like it needs reporting as a bug to r-lib/actions.

Done: https://github.com/r-lib/actions/issues/898

MichaelChirico commented 1 month ago

Still waver a bit on whether signalling a condition is really the right thing to do for code that's performing fine, in fact congratulatory.

But, I don't think it actually matters -- we are a "front end" package & I can't think of any scenario where the difference between cat()/message() would actually matter for our users. So, let's proceed for simplicity's sake.