r-lib / marquee

Markdown Parser and Renderer for R Graphics
https://marquee.r-lib.org
Other
69 stars 2 forks source link

Stress testing #7

Open thomasp85 opened 2 months ago

thomasp85 commented 2 months ago

I still get the occasional crash when resizing windows... needs to investigate

teunbrand commented 1 month ago

Unrelated to resizing, but I also encountered a crash when I was (foolishly) trying to modify objects manually (as modify_style() works on style sets, not individual styles). Recall that list-assignment of NULL does not set a list element to NULL, but rather removes the element from the list.

[!WARNING] Crashes R sessions

library(marquee)

tag <- style()
tag$color <- NULL

style <- classic_style() |>
  modify_style("foo", tag)

grob <- marquee_grob("Lorem {.foo ipsum}", style)
thomasp85 commented 3 weeks ago

Fixed by 697bdbe. you can now modify style objects with modify_style() and standard setters are blocked