Open DavisVaughan opened 2 years ago
I have a failing built which tries to install the foreign package which is also a recommended package (and now requires 4.0.0): https://github.com/tidymodels/censored/pull/82/checks?check_run_id=3806116333
@hfrick Why does the same thing work on Linux? https://github.com/tidymodels/censored/pull/82/checks?check_run_id=3806116558#step:5:234
I was wondering the same thing :sweat_smile:
Seeing this on themis as well cc @EmilHvitfeldt
AFAICT themis needs progressr, which needs R 3.5.0, so even if this issue is solved, you won't be able to install it on R 3.4.x:
❯ pak::pkg_deps_explain("tidymodels/themis", "progressr")
themis -> recipes -> ipred -> prodlim -> lava -> progressr
@DavisVaughan the same is true for hardhat, seemingly:
> pak::pkg_deps_explain("tidymodels/hardhat", "progressr", dependencies = TRUE)
hardhat -> recipes -> ipred -> prodlim -> lava -> progressr
progressr is a hard dependency of recipes (both CRAN and GH versions), so anything that needs recipes needs at least R 3.5.0:
> pak::pkg_deps_explain("recipes", "progressr")
recipes -> ipred -> prodlim -> lava -> progressr
> pak::pkg_deps_explain("tidymodels/recipes", "progressr")
recipes -> ipred -> prodlim -> lava -> progressr
@hfrick as for censored, riskRegression is a hard dependency and it needs R 3.5.0:
❯ pak::pkg_deps_explain("tidymodels/censored", "riskRegression")
censored -> pec -> riskRegression
and glmnet is a dev-dependency, and that need R 3.6.0.
I'm going to add a reminder here (most of the folks on this thread probably remember) that about a month ago, we had to move recipes to R>=4.0.0 because of fastICA. Anything that tries to build recipes will now need to stick to R>=4.0.0.
EDIT: Wait, that can't be right??? Because themis is now building back to oldrel-3
?
On this GHA build we get the unfortunate error with no extra context: https://github.com/tidymodels/hardhat/runs/3768720403
Run locally, we get the following:
Matrix is a recommended package, which should already be installed, but we currently don't have a way to tell pak to use it and that seems to be related to this issue