search

r-lib / pak

A fresh approach to package installation
https://pak.r-lib.org
678 stars 63 forks source link

`?ignore`d packages is not ignored #423

Closed billdenney closed 2 years ago

billdenney commented 2 years ago

Related to #421, I'm trying to ignore the package lixoftConnectors when installing dependencies.

When I used lixoftConnectors?ignore in the extra-packages list, I got the following error indicating that it was not ignored:

https://github.com/nlmixr2/babelmixr2/actions/runs/3169455077/jobs/5161378366#step:5:109

The instructions I used were:

https://github.com/nlmixr2/babelmixr2/blob/5bd330353cf4ad0b62d0223b656246672119e3b1/.github/workflows/R-CMD-check.yaml#L45-L55

I was trying to follow the instructions here: https://github.com/r-lib/actions/tree/v2-branch/setup-r-dependencies#ignoring-optional-dependencies

gaborcsardi commented 2 years ago

The syntax is slightly different:

❯ pak::lockfile_create(c("deps::.", "lixoftConnectors=?ignore"), dependencies = TRUE)
✔ Created lockfile pkg.lock [547ms]
billdenney commented 2 years ago

First, thank you for being so responsive right now. It's very helpful to working through this issue (or these issues)!

I fixed the ignore syntax, but it appears to want to be able to find the package. I now see the same subscript out of bounds error as in #421.

I'm now trying adding the repository back in with extra-repositories: 'https://monolix.lixoft.com/monolix-api/lixoftconnectors_installation/'. (But my baby is waking up, so I'm now done working on it for several hours at least 😄 .)

billdenney commented 2 years ago

The installation is still not succeeding. I think that I've covered all the main steps as I see them documented:

Can you please help identify what the remaining issue is?

gaborcsardi commented 2 years ago

Can you link to the failing build?

billdenney commented 2 years ago

Here is the GitHub action log: https://github.com/nlmixr2/babelmixr2/actions/runs/3169571113

And, here is the commit that ran it: https://github.com/nlmixr2/babelmixr2/tree/930968565d70a20e7f4c715baf86e9ed2ded7dd3

If you were looking for something else, please let me know.

gaborcsardi commented 2 years ago

This was a bug in pkgdepends, unfortunately. I'll build new pak binaries and then GHA should be fine.

gaborcsardi commented 2 years ago

Try it again please, hopefully it works now.

billdenney commented 2 years ago

@gaborcsardi , I ran this again about 2 hours ago (without modification), and I was still getting the same issue. Should it have succeeded or is there a delay for changes to propogate?

https://github.com/nlmixr2/babelmixr2/actions/runs/3169571113/jobs/5172821660 (note that the running time is 1 hour ago)

gaborcsardi commented 2 years ago

It was deployed less than an hour ago.

billdenney commented 2 years ago

Success! Thank you!

(Well, I still have some work to do as there are testing errors, but the CI seems to be working correctly. 😄 )