r-lib / pak

A fresh approach to package installation
https://pak.r-lib.org
671 stars 60 forks source link

Make config/needs/* case insensitive #459

Open eitsupi opened 1 year ago

eitsupi commented 1 year ago

I'm looking for a way to install the development dependencies for a package, and running something like local_install_dev_deps(dependencies = c("config/needs/website")) seems to give me an error.

> pak::local_install_dev_deps(dependencies = c("config/needs/website"))
Error: 
! error in pak subprocess
Caused by error: 
! Could not solve package dependencies:
* deps::/workspaces/prqlr:
  * Can't install dependency pkgdown
  * Can't install dependency extendr/rextendr
Type .Last.error to see the more details.

https://github.com/eitsupi/prqlr/blob/f7d5dadefa96224459fe9613850342154404b383/DESCRIPTION#L41-L43

I thought it might be due to referencing packages on GitHub, but the same error occurred when I left the CRAN package alone.

gaborcsardi commented 1 year ago

Unfortunately this is case sensitive, so until we fix this you need to write:

pak::local_install_dev_deps(dependencies = c("Config/Needs/website"))

Btw. you probably also want the "regular" dependencies:

pak::local_install_dev_deps(dependencies = c("Config/Needs/website", "all"))
eitsupi commented 1 year ago

Unfortunately this is case sensitive, so until we fix this you need to write:

pak::local_install_dev_deps(dependencies = c("Config/Needs/website"))

Btw. you probably also want the "regular" dependencies:

pak::local_install_dev_deps(dependencies = c("Config/Needs/website", "all"))

Thank you for response, that works! I was unaware of the possibility that lowercase letters were the cause because the error message showed the package correctly......