search

r-lib / pak

A fresh approach to package installation
https://pak.r-lib.org
671 stars 60 forks source link

Update embed-ca-certs.R #545

Closed SermetPekin closed 11 months ago

SermetPekin commented 11 months ago

to let user pass some arguments (method argument in this case) to utils::download.file method whenever it needs to be called. method such as "wininet" / "libcurl" . In this PR I suggested an override method download_file which checks environment variable pak_ENV_download_file_method if it is set

gaborcsardi commented 11 months ago

I recon you don't need this anymore?

SermetPekin commented 11 months ago

Hi Gábor,

i will do it later from my personal computer. witg my work computer i had some issues sending two files. just a small tweak actually. thank you very much for awesome work cli and pak as far as I happened to know. have a nice day.

Sermet

On Sat, Oct 28, 2023, 12:15 Gábor Csárdi @.***> wrote:

I recon you don't need this anymore?

— Reply to this email directly, view it on GitHub https://github.com/r-lib/pak/pull/545#issuecomment-1783756711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXBMMXUCPFTJ32VXY6BTEMLYBTEMFAVCNFSM6AAAAAA6TMTXRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTG42TMNZRGE . You are receiving this because you modified the open/close state.Message ID: @.***>