r-lib / pak

A fresh approach to package installation
https://pak.r-lib.org
642 stars 56 forks source link

Weird issue with prettyunits on GHA #568

Closed krlmlr closed 6 months ago

krlmlr commented 6 months ago

https://github.com/krlmlr/bindrcpp/actions/runs/7108392065/job/19359651833#step:6:4003

! error in pak subprocess
  Caused by error in `loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]])`:
  ! there is no package called ‘prettyunits’

Does this ring a bell? There's only one repo where I'm seeing this, couldn't replicate.

gaborcsardi commented 6 months ago

Is it possible that this uses some cached version of dev pak that is buggy?

krlmlr commented 6 months ago

It's a repo where I have enabled GHA only yesterday. Could it be that prettyunits is expected in the global package library for some reason, but not installed there?

The sister repo has no such issues: https://github.com/krlmlr/bindr/actions/runs/7111477960.

gaborcsardi commented 6 months ago

The current devel version might be broken? Did you try the stable version?

krlmlr commented 6 months ago

https://github.com/krlmlr/bindrcpp/pull/10

krlmlr commented 6 months ago

Stable pak looks good. Going to devel pak in the same PR to double-check.

krlmlr commented 6 months ago

Works now. I'll see if this works in the nightly run on the main branch.

krlmlr commented 6 months ago

The issue persists in the nightly run: https://github.com/krlmlr/bindrcpp/actions/runs/7122012607/job/19392351925 .

Can you work with that? I've invited you to the repo. Happy to provide more context if needed.

gaborcsardi commented 6 months ago

This is fixed by https://github.com/r-lib/pkgdepends/commit/fa202b03e7b7832776433cac0dceafb4a4590a60 I believe. I'll build Linux binary packages now, the rest will be built overnight.

krlmlr commented 6 months ago

Thanks! I'll watch my nightly CI/CD runs.

gaborcsardi commented 6 months ago

I believe that this is fixed now.

krlmlr commented 6 months ago

Thanks, confirmed!