r-lib / pak

A fresh approach to package installation
https://pak.r-lib.org
682 stars 62 forks source link

Outdated metadata generated by `lockfile_create()` #678

Closed shikokuchuo closed 1 month ago

shikokuchuo commented 3 months ago
pak::lockfile_create("mirai")

creates the following for me:

{
  "lockfile_version": 1,
  "os": "Ubuntu 22.04.4 LTS",
  "r_version": "R version 4.4.1 (2024-06-14)",
  "platform": "x86_64-pc-linux-gnu",
  "packages": [
    {
      "ref": "mirai",
      "package": "mirai",
      "version": "1.2.0",
      "type": "standard",
      "direct": true,
      "binary": false,
      "dependencies": ["nanonext"],
      "vignettes": false,
      "needscompilation": false,
      "metadata": {
        "RemoteType": "standard",
        "RemotePkgRef": "mirai",
        "RemoteRef": "mirai",
        "RemoteRepos": "https://cloud.r-project.org",
        "RemotePkgPlatform": "source",
        "RemoteSha": "1.2.0"
      },
      "sources": ["https://cloud.r-project.org/src/contrib/mirai_1.2.0.tar.gz", "https://cloud.r-project.org/src/contrib/Archive/mirai/mirai_1.2.0.tar.gz"],
      "target": "src/contrib/mirai_1.2.0.tar.gz",
      "platform": "source",
      "rversion": "*",
      "directpkg": true,
      "license": "GPL (>= 3)",
      "filesize": 125941,
      "dep_types": ["Depends", "Imports", "LinkingTo"],
      "params": [],
      "install_args": "",
      "repotype": "cran",
      "sysreqs": "",
      "sysreqs_packages": {}
    },
    {
      "ref": "nanonext",
      "package": "nanonext",
      "version": "1.2.1",
      "type": "standard",
      "direct": false,
      "binary": false,
      "dependencies": [],
      "vignettes": false,
      "needscompilation": true,
      "metadata": {
        "RemoteType": "standard",
        "RemotePkgRef": "nanonext",
        "RemoteRef": "nanonext",
        "RemoteRepos": "https://cloud.r-project.org",
        "RemotePkgPlatform": "source",
        "RemoteSha": "1.2.1"
      },
      "sources": ["https://cloud.r-project.org/src/contrib/nanonext_1.2.1.tar.gz", "https://cloud.r-project.org/src/contrib/Archive/nanonext/nanonext_1.2.1.tar.gz"],
      "target": "src/contrib/nanonext_1.2.1.tar.gz",
      "platform": "source",
      "rversion": "*",
      "directpkg": false,
      "license": "GPL (>= 3)",
      "filesize": 766964,
      "dep_types": ["Depends", "Imports", "LinkingTo"],
      "params": [],
      "install_args": "",
      "repotype": "cran",
      "sysreqs": "'libnng' >= 1.5 and 'libmbedtls' >= 2.5, or 'cmake' to compile NNG and/or Mbed TLS included in package sources",
      "sysreqs_packages": [
        {
          "sysreq": "cmake",
          "packages": ["cmake"],
          "pre_install": {},
          "post_install": {}
        }
      ]
    }
  ]
}

The following lines are stale for nanonext: "dep_types": ["Depends", "Imports", "LinkingTo"], "sysreqs": "'libnng' >= 1.5 and 'libmbedtls' >= 2.5, or 'cmake' to compile NNG and/or Mbed TLS included in package sources",

I updated the sysreqs in response to https://github.com/r-hub/rhub/issues/600#issuecomment-2065320987 and this has been for the past couple of package releases: 'libnng' >= 1.6 and 'libmbedtls' >= 2.5, or 'cmake' and 'xz' to compile NNG and/or Mbed TLS included in package sources

It is manifesting in rhub runs e.g. at: https://github.com/shikokuchuo/mirai/actions/runs/10455991607/job/28952283109#step:5:725 Clearing the GitHub cache files had no effect for me.

Not sure what this is, hopefully you might have an idea. Thanks.

gaborcsardi commented 1 month ago

I am sorry for the delay, this should be fixes now.

shikokuchuo commented 1 month ago

Looks good. Thanks!