r-lib / pillar

Format columns with colour
https://pillar.r-lib.org/
Other
178 stars 37 forks source link

feat: New `tbl_nrow()` to support lazy data frames #679

Closed krlmlr closed 6 days ago

krlmlr commented 1 week ago

Necessary for duckplyr because dim(x) still dispatches to dim.data.frame() for subclasses of "data.frame" .

Includes other refactorings.

hadley commented 6 days ago

Would you mind pulling the style changes into a separate PR? That would make it easier to see what you're proposing here.

krlmlr commented 6 days ago

The important commit is the last one, ba184c34 . You could take a look at that, I'll also split this PR.